[OpenSRF-GIT] OpenSRF branch rel_2_1 updated. osrf_rel_2_1_2-5-g8c50b55

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenSRF".

The branch, rel_2_1 has been updated
       via  8c50b55dc7e7c706976a40a2a3926073fb2f8ff2 (commit)
      from  6a2d71f9a20ca62be8c74479e6d77d07d03ddbb5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8c50b55dc7e7c706976a40a2a3926073fb2f8ff2
Author: Bill Erickson <berick at esilibrary.com>
Date:   Tue Jun 26 09:21:57 2012 -0400

    Prevent "uninitialized value" warnings in parameter logging
    
    Use of uninitialized value $p[0] in join or string at
    /usr/local/share/perl/5.10.1/OpenSRF/Application.pm line 130.
    
    This is caused when the array of method params contains null/undef
    values.  Prevent the warnings by replacing these values w/ empty
    strings.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

diff --git a/src/perl/lib/OpenSRF/Application.pm b/src/perl/lib/OpenSRF/Application.pm
index 9283b7f..0a5c188 100644
--- a/src/perl/lib/OpenSRF/Application.pm
+++ b/src/perl/lib/OpenSRF/Application.pm
@@ -146,7 +146,7 @@ sub handler {
 			if ($redact_params) {
 				$logdata .= "**PARAMS REDACTED**";
 			} else {
-				$logdata .= join(', ', at p);
+				$logdata .= join(', ', map { (defined $_) ? $_ : '' } @p);
 			}
 		}
 		$log->info($logdata);

-----------------------------------------------------------------------

Summary of changes:
 src/perl/lib/OpenSRF/Application.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
OpenSRF