[OPEN-ILS-DEV] lib-setup.cgi funkyness

[Bill Ott]

I was setting up a quick demo system and grabbed a copy of Dan's Gentoo 
VMware image.  ...not sure that any of that's relevant.

While making some tree changes, I saw some odd behavior with 
lib-setup.cgi.  Specifically, the current tree displayed would change to 
a previous revision as I proceeded to make the next change.  I later 
realized that quick reload corrected the view, but I got curious as to 
where might the issue lie.


I cranked up the logging for Apache and found these, not entirely sure 
if they're related.


[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Subroutine 
compile redefined at 
/openils/lib/perl5/OpenILS/Application/Storage/Driver/Pg/fts.pm line 9., 
referer: http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8
[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Subroutine 
sql_where_clause redefined at 
/openils/lib/perl5/OpenILS/Application/Storage/Driver/Pg/fts.pm line 
49., referer: http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8
[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Subroutine 
sql_exact_phrase_match redefined at 
/openils/lib/perl5/OpenILS/Application/Storage/Driver/Pg/fts.pm line 
65., referer: http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8
[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Subroutine 
current_xact redefined at 
/openils/lib/perl5/OpenILS/Application/Storage/Driver/Pg/storage.pm line 
14., referer: http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8
[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Use of 
uninitialized value in numeric gt (>) at 
/openils/lib/perl5/OpenSRF/Utils/Logger.pm line 216., referer: 
http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8
[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Use of 
uninitialized value in pattern match (m//) at 
/openils/var/cgi-bin/lib-setup.cgi line 35., referer: 
http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8
[Tue Sep 25 14:22:31 2007] [error] [client 172.16.64.51] Use of 
uninitialized value in numeric gt (>) at 
/openils/lib/perl5/OpenSRF/Utils/Logger.pm line 216., referer: 
http://172.16.65.231/cgi-bin/lib-setup.cgi?action=child&id=8



Prior to this, I had essentially destroyed the tree by not noticing the 
difference in the tree and making changes.  Unfortunately I didn't note 
exactly what I saw before simply dumping back in a default database, but 
I do remember that the HTML returned displayed the Javascript for each 
tree.add() call as plain text.  Looking at the source, I found this:


<h1>Library Hierarchy Setup</h1>

	tree.add(1, -1, "Example Consortium", "lib-setup.cgi?action=child&id=1", "Example Consortium");
	...


Where the <script> tag  and call to dTree() was missing.


I haven't had a chance to dig into it any further, but thought it might 
be worth noting.