[OPEN-ILS-DEV] Sorting by distance in the OPAC - Patch

[Paul Waak]

Oh yea! Shoot!  Thank you for commenting on that.

I was using the North Texas information for testing the lat-long  
values.  I meant to swap those two seed files before making the final  
patch.  The lesson here is don't submit a patch at 2AM.  Now that I am  
more alert, I realize it would be better to submit the test data  
separately.

Here is the intended patch.  The file 950.data.seed-values-latlong.sql  
is for those who want to look at the distance sorting without spending  
time looking up the lat-long values for their own libraries.

Incidentally, I deliberately chose not to just assign fictitious lat- 
long values to the existing sample OUs.  I went down that path when I  
first started testing, and it was very hard to visualize whether the  
system was behaving properly.  I suspect other testers will have  
similar problems.  Real places just make it easier.  This way, the  
places can be entered into google maps/earth and compared to the OPAC  
display.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: DistSort090820.diff
Type: application/octet-stream
Size: 31533 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20090820/2d95b4b7/attachment-0002.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 950.data.seed-values-latlong.sql
Type: application/octet-stream
Size: 141929 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20090820/2d95b4b7/attachment-0003.obj 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: DCO-1.1.txt
Url: http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20090820/2d95b4b7/attachment-0001.txt 
-------------- next part --------------


On Aug 20, 2009, at 9:57 AM, Galen Charlton wrote:

> Hi Paul,
>
> On Thu, Aug 20, 2009 at 2:06 AM, Paul Waak<ptwaak at gmail.com> wrote:
>> Hello EG Gurus,
>
> I'm not one yet, but I'm diving in anyway:
>
>> Here is my first foray into open-ils patching.
>
> FIrst, thanks!  This looks like an interesting feature.  I'll leave it
> to others to comment about the specifics of it, but one thing about
> the organization of your patch did jump out at me:
>
>> patching file Open-ILS/src/sql/Pg/950.data.seed-values.sql
>
> Your patch currently seems to be replacing the sample OUs with a
> version of the whole North Texas OU hierarchy - I think it would be
> better to just update two or more of the existing sample OUs with
> latitudes and longitudes.
>
>> patching file Open-ILS/src/sql/Pg/orig.950.data.seed-values.sql
>
> It's not necessary to add a duplicate copy of the 950 seed script via
> your patch.
>
> Regards,
>
> Galen
> -- 
> Galen Charlton
> Equinox
> gmc at esilibrary.com
> gmcharlt at gmail.com

Paul Waak
pwaak at yahoo.com
North Texas Library Consortium, Advisor