[OPEN-ILS-DEV] opensrf.js Unit Tests and Fix

[Kevin Beswick]

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Kevin Beswick <kevinbeswick00 at gmail.com>

On Sun, May 8, 2011 at 2:07 PM, Dan Scott <dan at coffeecode.net> wrote:
> On Thu, Apr 14, 2011 at 3:53 PM, Kevin Beswick <kevinbeswick00 at gmail.com> wrote:
>> Hello,
>>
>> Attached are two patches. The first one contains some unit tests for
>> the first half of opensrf.js. These make use of the DOH (Dojo
>> Objective Harness) framework that Dan Scott had put into place in this
>> commit: http://svn.open-ils.org/trac/OpenSRF/changeset/2217/
>>
>> The second patch contains a fix for a bug I found in opensrf.js while
>> writing the unit tests. There were references to arguments that
>> weren't declared in several of the function declarations. Natually,
>> many of the unit tests will not pass until this fix is put into place.
>
> Hi Kevin:
>
> The tests look good, and I would like to add them to OpenSRF proper.
> Can you please attach a DCO for the unit tests, per
> http://evergreen-ils.org/dokuwiki/doku.php?id=dev:contributing ?
>
> (By the way, if someone wants to start drafting up a replacement for
> that wiki page that formally adopts / adapts the "Signed-off-by:"
> convention from the Linux kernel and sundry other projects, it would
> be great to line that up with our move to git in a week or so).
>
> Dan
>